[Low Code CDK] Fix missing stream name #21658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clnoll
force-pushed
the
fix-missing-stream-name
branch
from
379d8c3 to
0a276a0
Compare
clnoll
force-pushed
the
fix-missing-stream-name
branch
from
0a276a0 to
b562e22
Compare
brianjlai
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21381
Revisit #21516, which was reverted due to test failures associated with the creation of
DefaultSchemaLoaderwhen created as part of a subcomponent.This solution passes
nameintooptionsin thecreate_declarative_streamfunction. It's also more consistent with the use of component classes, which don't take arguments other thanoptions.